Clean up and refactor IngameWindow button handling #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falbrechtskirchinger
force-pushed
the
refactor-ingamewindow
branch
from
321e33a to
ec9c289
Compare
Flamefire
requested changes
Jul 18, 2023
falbrechtskirchinger
force-pushed
the
refactor-ingamewindow
branch
2 times, most recently
from
3df993a to
9358be6
Compare
|
Had to move the enum out of the class, as |
Flamefire
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Had to move the enum out of the class, as maxEnumValue(ButtonId) isn't usable in an incomplete class context.
Shame but unfortunately true :(
Last bit of polishing is mostly getting rid of the remnants of the button ID: Rename the enum and all variables of that type (from ìdto e.g.buttonorbt`)
falbrechtskirchinger
force-pushed
the
refactor-ingamewindow
branch
from
9358be6 to
eb9af47
Compare
6 tasks
falbrechtskirchinger
force-pushed
the
refactor-ingamewindow
branch
from
eb9af47 to
8362ac7
Compare
falbrechtskirchinger
force-pushed
the
refactor-ingamewindow
branch
from
c4cbc99 to
8362ac7
Compare
Flamefire
reviewed
Jul 19, 2023
falbrechtskirchinger
force-pushed
the
refactor-ingamewindow
branch
from
8362ac7 to
f6fb9c2
Compare
Flamefire
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_down,last_down2).I'll rebase #1606 and implement discussed changes before this is ready for consideration.